From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbcDYM5X (ORCPT ); Mon, 25 Apr 2016 08:57:23 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:46949 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932298AbcDYM5W (ORCPT ); Mon, 25 Apr 2016 08:57:22 -0400 Date: Mon, 25 Apr 2016 14:57:18 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering Message-ID: <20160425125718.GC3448@twins.programming.kicks-ass.net> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index b717902c99..4f968d6b96 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -151,6 +151,15 @@ struct hw_perf_event { > */ > struct task_struct *target; > > + /* > + * PMU would store hardware filter configuration > + * here. > + */ > + void *addr_filters; > + > + /* Last sync'ed generation of filters */ > + unsigned long addr_filters_gen; > + should these not go in the itrace struct? /me continues reading