From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657AbcDYNUK (ORCPT ); Mon, 25 Apr 2016 09:20:10 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:46004 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932166AbcDYNUJ (ORCPT ); Mon, 25 Apr 2016 09:20:09 -0400 Date: Mon, 25 Apr 2016 15:19:59 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering Message-ID: <20160425131959.GE3448@twins.programming.kicks-ass.net> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote: > @@ -393,12 +405,64 @@ struct pmu { > void (*free_aux) (void *aux); /* optional */ > > /* > + * Validate address range filters: make sure hw supports the > + * requested configuration and number of filters; return 0 if the > + * supplied filters are valid, -errno otherwise. > + */ > + int (*addr_filters_validate) (struct list_head *filters); > + /* optional */ > + > + /* > + * Synchronize address range filter configuration: > + * translate hw-agnostic filter into hardware configuration in > + * event::hw::addr_filters. > + */ > + void (*addr_filters_sync) (struct perf_event *event); > + /* optional */ So these two are not serialized the 'normal' way right? Does that want more comment?