From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754592AbcDYOO0 (ORCPT ); Mon, 25 Apr 2016 10:14:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41455 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbcDYOOZ (ORCPT ); Mon, 25 Apr 2016 10:14:25 -0400 Date: Mon, 25 Apr 2016 16:14:20 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering Message-ID: <20160425141420.GI3430@twins.programming.kicks-ass.net> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote: > /** > + * struct perf_addr_filter - address range filter definition > + * @entry: event's filter list linkage > + * @inode: object file's inode for file-based filters > + * @offset: filter range offset > + * @size: filter range size > + * @range: 1: range, 0: address > + * @filter: 1: filter/start, 0: stop > + * @kernel: 1: kernel, 0: file-based > + * > + * This is a hardware-agnostic filter configuration as specified by the user. > + */ > +struct perf_addr_filter { > + struct list_head entry; > + struct inode *inode; > + unsigned long offset; > + unsigned long size; > + unsigned int range : 1, > + filter : 1, > + kernel : 1; > +}; FWIW, why not have !inode be kernel?