From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754773AbcDYOZL (ORCPT ); Mon, 25 Apr 2016 10:25:11 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48017 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbcDYOZJ (ORCPT ); Mon, 25 Apr 2016 10:25:09 -0400 Date: Mon, 25 Apr 2016 16:25:06 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v1 4/5] perf: Introduce address range filtering Message-ID: <20160425142506.GJ3430@twins.programming.kicks-ass.net> References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com> <1461251823-12416-5-git-send-email-alexander.shishkin@linux.intel.com> <20160422074555.GB3448@twins.programming.kicks-ass.net> <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zisl8vls.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote: > +/* > + * Address range filtering: limiting the data to certain > + * instruction address ranges. Filters are ioctl()ed to us from > + * userspace as ascii strings. > + * > + * Filter string format: > + * > + * ACTION SOURCE:RANGE_SPEC > + * where ACTION is one of the > + * * "filter": limit the trace to this region > + * * "start": start tracing from this address > + * * "stop": stop tracing at this address/region; > + * SOURCE is either "file" or "kernel" > + * RANGE_SPEC is > + * * for "kernel": [/] > + * * for "file": [/]@ SOURCE seems entirely redundant > + * > + * if is not specified, the range is treated as a single address. single instruction, right?