From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933058AbcDYQX0 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 12:23:26 -0400
Received: from mail-wm0-f42.google.com ([74.125.82.42]:35872 "EHLO
	mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932935AbcDYQXZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 12:23:25 -0400
Date: Mon, 25 Apr 2016 17:23:24 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-kernel@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>,
        Felipe Balbi <balbi@ti.com>,
        Santosh Shilimkar <santosh.shilimkar@ti.com>,
        Sourav Poddar <sourav.poddar@ti.com>
Subject: Re: [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback
Message-ID: <20160425162324.GN2713@dell>
References: <1461240939-21110-1-git-send-email-ldewangan@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1461240939-21110-1-git-send-email-ldewangan@nvidia.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 21 Apr 2016, Laxman Dewangan wrote:

> SMSC MFD driver does not add any MFD child devices via
> mfd_add_devices() and hence it is not required to call
> mfd_remove_devices() to remove MFD child devices.
> 
> Remove the call of the API mfd_remove_devices() which will
> result as remove of .remove callback for driver.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> This is build and compile tested only.
> 
>  drivers/mfd/smsc-ece1099.c | 10 ----------
>  1 file changed, 10 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
> index a4c0df7..7f89e89 100644
> --- a/drivers/mfd/smsc-ece1099.c
> +++ b/drivers/mfd/smsc-ece1099.c
> @@ -80,15 +80,6 @@ err:
>  	return ret;
>  }
>  
> -static int smsc_i2c_remove(struct i2c_client *i2c)
> -{
> -	struct smsc *smsc = i2c_get_clientdata(i2c);
> -
> -	mfd_remove_devices(smsc->dev);
> -
> -	return 0;
> -}
> -
>  static const struct i2c_device_id smsc_i2c_id[] = {
>  	{ "smscece1099", 0},
>  	{},
> @@ -100,7 +91,6 @@ static struct i2c_driver smsc_i2c_driver = {
>  		   .name = "smsc",
>  	},
>  	.probe = smsc_i2c_probe,
> -	.remove = smsc_i2c_remove,
>  	.id_table = smsc_i2c_id,
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog