From: Stephen Boyd <sboyd@codeaurora.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
andrew@lunn.ch, gregory.clement@free-electrons.com,
Jason Cooper <jason@lakedaemon.net>,
sebastian.hesselbarth@gmail.com,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms without operating-points-v2
Date: Mon, 25 Apr 2016 14:56:08 -0700 [thread overview]
Message-ID: <20160425215608.GB29990@codeaurora.org> (raw)
In-Reply-To: <CAJZ5v0htz=F29BAkkGR3XPa1F15o0qg_pUbcPkqbY-COD8UDsQ@mail.gmail.com>
On 04/25, Rafael J. Wysocki wrote:
> On Mon, Apr 25, 2016 at 11:45 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 04/25, Viresh Kumar wrote:
> >> On 22-04-16, 15:27, Stephen Boyd wrote:
> >> > On 04/21, Viresh Kumar wrote:
> >> > > @@ -167,14 +167,16 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> >> > > /* Get OPP-sharing information from "operating-points-v2" bindings */
> >> > > ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus);
> > [..]
> >> > > + if (dev_pm_opp_get_sharing_cpus(cpu_dev, policy->cpus))
> >> > > + fallback = true;
> >> >
> >> > I'm sort of lost, we make the same call twice here. Why would the
> >> > return value change between the first time and the second?
> >>
> >> Two different APIs, which look similar :)
> >>
> >> The first one tries to find the sharing-cpus relation from DT, the
> >> other one is for v1 bindings and finds it due to platform code
> >> dev_pm_opp_set_sharing_cpus() call.
> >
> > Ah thanks. My eyes glossed over the "of" part. Sounds fine.
>
> So that would be an "ACK", right?
Sure, I thought this was going for another round though.
I had to go back and re-read the patch once more, but you can
have my reviewed-by on this one too.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-25 21:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1461228504.git.viresh.kumar@linaro.org>
2016-04-21 8:58 ` [PATCH 01/10] PM / OPP: Propagate the error returned by _find_opp_table() Viresh Kumar
2016-04-22 22:14 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 02/10] PM / OPP: Add missing doc style comments Viresh Kumar
2016-04-22 22:15 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 03/10] PM / OPP: dev_pm_opp_set_sharing_cpus() doesn't depend on CONFIG_OF Viresh Kumar
2016-04-22 22:16 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 04/10] PM / OPP: Relocate dev_pm_opp_set_sharing_cpus() Viresh Kumar
2016-04-22 22:22 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 05/10] PM / OPP: Mark shared-opp for non-dt case Viresh Kumar
2016-04-22 22:21 ` Stephen Boyd
2016-04-21 8:58 ` [PATCH 06/10] PM / OPP: Add dev_pm_opp_get_sharing_cpus() Viresh Kumar
2016-04-22 22:21 ` Stephen Boyd
2016-04-27 2:59 ` Viresh Kumar
2016-04-21 8:58 ` [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms without operating-points-v2 Viresh Kumar
2016-04-22 22:27 ` Stephen Boyd
2016-04-25 9:36 ` Viresh Kumar
2016-04-25 21:45 ` Stephen Boyd
2016-04-25 21:48 ` Rafael J. Wysocki
2016-04-25 21:56 ` Stephen Boyd [this message]
2016-04-25 22:03 ` Rafael J. Wysocki
2016-04-21 8:59 ` [PATCH 08/10] mvebu: Use dev_pm_opp_set_sharing_cpus() to mark OPP tables as shared Viresh Kumar
2016-04-22 22:24 ` Stephen Boyd
2016-04-21 8:59 ` [PATCH 09/10] cpufreq: dt: Kill platform-data Viresh Kumar
2016-04-22 22:26 ` Stephen Boyd
2016-04-21 8:59 ` [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver Viresh Kumar
2016-04-22 22:42 ` Arnd Bergmann
2016-04-25 3:00 ` Viresh Kumar
2016-04-25 12:53 ` Arnd Bergmann
2016-04-25 12:56 ` Viresh Kumar
2016-04-25 15:26 ` Arnd Bergmann
2016-04-25 15:29 ` Viresh Kumar
2016-04-25 15:46 ` Arnd Bergmann
2016-04-25 15:55 ` Thomas Petazzoni
2016-04-22 3:16 ` [PATCH] PM / OPP: -ENOSYS is applicable only to syscalls Viresh Kumar
2016-04-22 12:42 ` Rafael J. Wysocki
2016-04-22 14:59 ` One Thousand Gnomes
2016-04-27 2:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425215608.GB29990@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=arnd.bergmann@linaro.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox