From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbcDYX3Z (ORCPT ); Mon, 25 Apr 2016 19:29:25 -0400 Received: from mail.kernel.org ([198.145.29.136]:48799 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751860AbcDYX3Y (ORCPT ); Mon, 25 Apr 2016 19:29:24 -0400 Date: Mon, 25 Apr 2016 20:29:20 -0300 From: Arnaldo Carvalho de Melo To: Colin King Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Adrian Hunter , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: fix off-by-one comparison on maximum code Message-ID: <20160425232920.GB15298@kernel.org> References: <1461524203-10224-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461524203-10224-1-git-send-email-colin.king@canonical.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Apr 24, 2016 at 07:56:43PM +0100, Colin King escreveu: > From: Colin Ian King > > The check for the maximum code is off-by-one; the current > comparison of a code that is INTEL_PT_ERR_MAX will cause the > strlcpy to perform an out of bounds array access on the > intel_pt_err_msgs array. Fix this with a >= comparison. Applied, thanks. - Arnaldo > Signed-off-by: Colin Ian King > --- > tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > index 9409d01..9c8f15d 100644 > --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > @@ -356,7 +356,7 @@ static const char *intel_pt_err_msgs[] = { > > int intel_pt__strerror(int code, char *buf, size_t buflen) > { > - if (code < 1 || code > INTEL_PT_ERR_MAX) > + if (code < 1 || code >= INTEL_PT_ERR_MAX) > code = INTEL_PT_ERR_UNK; > strlcpy(buf, intel_pt_err_msgs[code], buflen); > return 0; > -- > 2.7.4