Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote:

This looks mostly good, a few small things below.

> +	switch (width) {
> +	case 16:
> +	case 18:
> +	case 20:
> +	case 24:
> +		/*
> +		 * We only support the different left-justified serial audio
> +		 * formats in which case there is nothing to configure in the
> +		 * TAS5720.
> +		 */
> +		break;
> +	default:
> +		dev_err(codec->dev, "unsupported sample size: %d\n", width);
> +		return -EINVAL;
> +	}

If the driver doesn't do anything just remove the code.

> +	if ((curr_fault & TAS5720_OCE) && !(tas5720->last_fault & TAS5720_OCE))
> +		dev_warn(dev, "The Class-D output stage has experienced an over current event\n");

"Class D over current".  The verbosity is making the line over long and
the phrasing is a bit unclear (and makes it seem less critical than it
really is).  These should probably be dev_crit() or somthing too, over
current and similar events on a speaker output are generally extremely
serious.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]