From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbcDZQTl (ORCPT ); Tue, 26 Apr 2016 12:19:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:53774 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbcDZQTi (ORCPT ); Tue, 26 Apr 2016 12:19:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,537,1455004800"; d="scan'208";a="792797075" Date: Tue, 26 Apr 2016 21:55:30 +0530 From: Vinod Koul To: okaya@codeaurora.org Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, shankerd@codeaurora.org, vikrams@codeaurora.org, marc.zyngier@arm.com, mark.rutland@arm.com, eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks Message-ID: <20160426162529.GK2274@localhost> References: <1460384473-5775-1-git-send-email-okaya@codeaurora.org> <1460384473-5775-3-git-send-email-okaya@codeaurora.org> <20160426033029.GB2274@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 08:08:16AM -0400, okaya@codeaurora.org wrote: > On 2016-04-25 23:30, Vinod Koul wrote: > >On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > > > >>+static int hidma_chan_stats(struct seq_file *s, void *unused) > >>+{ > >>+ struct hidma_chan *mchan = s->private; > >>+ struct hidma_desc *mdesc; > >>+ struct hidma_dev *dmadev = mchan->dmadev; > >>+ > >>+ pm_runtime_get_sync(dmadev->ddev.dev); > > > >debug shouldn't power up device, why do you want to do that > > > Clocks are turned off while the hw is idle. I can’t reach hw > registers without restoring power. Hmm, have you thought about using regmap? -- ~Vinod