public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: dmaengine@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nadav Haklai <nadavh@marvell.com>,
	Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Romain Perier <romain.perier@free-electrons.com>,
	Omri Itach <omrii@marvell.com>, Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH v3 1/5] dmaengine: mv_xor: make the code 64 bits compliant
Date: Tue, 26 Apr 2016 22:03:19 +0530	[thread overview]
Message-ID: <20160426163319.GO2274@localhost> (raw)
In-Reply-To: <1460652818-14647-2-git-send-email-gregory.clement@free-electrons.com>

On Thu, Apr 14, 2016 at 06:53:34PM +0200, Gregory CLEMENT wrote:
> Fix two warnings which appear when building for 64 bits target.

It is a good practice to post the warnings in log so that people know what
is being fixed

> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/dma/mv_xor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 3922a5d56806..a6ec82776cbc 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -477,7 +477,7 @@ mv_xor_prep_dma_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src,
>  	BUG_ON(len > MV_XOR_MAX_BYTE_COUNT);
>  
>  	dev_dbg(mv_chan_to_devp(mv_chan),
> -		"%s src_cnt: %d len: %u dest %pad flags: %ld\n",
> +		"%s src_cnt: %d len: %zu dest %pad flags: %ld\n",
>  		__func__, src_cnt, len, &dest, flags);
>  
>  	sw_desc = mv_chan_alloc_slot(mv_chan);
> @@ -1220,7 +1220,7 @@ static int mv_xor_probe(struct platform_device *pdev)
>  			struct mv_xor_chan *chan;
>  			dma_cap_mask_t cap_mask;
>  			int irq;
> -			op_in_desc = (int)of_id->data;
> +			op_in_desc = (uintptr_t)of_id->data;
>  
>  			if (i >= max_channels)
>  				continue;
> -- 
> 2.5.0
> 

-- 
~Vinod

  reply	other threads:[~2016-04-26 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 16:53 [PATCH v3 0/5] Add XOR engine support to Armada 3700 SoC (ARM64) Gregory CLEMENT
2016-04-14 16:53 ` [PATCH v3 1/5] dmaengine: mv_xor: make the code 64 bits compliant Gregory CLEMENT
2016-04-26 16:33   ` Vinod Koul [this message]
2016-04-14 16:53 ` [PATCH v3 2/5] dmaengine: mv_xor: use SoC type instead of directly the operation mode Gregory CLEMENT
2016-04-14 16:53 ` [PATCH v3 3/5] dmaengine: mv_xor: add support for Armada 3700 SoC Gregory CLEMENT
2016-04-26 16:37   ` Vinod Koul
2016-04-14 16:53 ` [PATCH v3 4/5] dmaengine: mv_xor: Allow selecting mv_xor for mvebu only compatible SoC Gregory CLEMENT
2016-04-14 16:53 ` [PATCH v3 5/5] arm64: dts: marvell: add XOR node for Armada 3700 SoC Gregory CLEMENT
2016-04-26  3:35   ` Vinod Koul
2016-04-26  7:28     ` Thomas Petazzoni
2016-04-26 16:32       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426163319.GO2274@localhost \
    --to=vinod.koul@intel.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=omrii@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=romain.perier@free-electrons.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox