From: Guenter Roeck <linux@roeck-us.net>
To: Joe Perches <joe@perches.com>
Cc: Colin King <colin.king@canonical.com>,
Wim Van Sebroeck <wim@iguana.be>,
Jiri Kosina <trivial@kernel.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
Date: Tue, 26 Apr 2016 09:50:00 -0700 [thread overview]
Message-ID: <20160426165000.GA30901@roeck-us.net> (raw)
In-Reply-To: <1461648139.2726.119.camel@perches.com>
On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote:
> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
> > fix spelling mistake, alloacate -> allocate
> []
> > diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> []
> > @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> > drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
> > GFP_KERNEL);
> > if (!drvdata) {
> > - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> > + dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
>
> Might as well delete this line instead.
>
Excellent point.
Colin, please resend and just drop the error message. It is not needed
because an error message is already printed by devm_kzalloc().
Thanks,
Guenter
next prev parent reply other threads:[~2016-04-26 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 19:19 [PATCH] watchdog: trivial fix of spelling mistake on "allocate" Colin King
2016-04-26 1:41 ` Guenter Roeck
2016-04-26 5:22 ` Joe Perches
2016-04-26 16:50 ` Guenter Roeck [this message]
2016-04-26 17:19 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426165000.GA30901@roeck-us.net \
--to=linux@roeck-us.net \
--cc=colin.king@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox