From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbcDZTwF (ORCPT ); Tue, 26 Apr 2016 15:52:05 -0400 Received: from muru.com ([72.249.23.125]:52248 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcDZTwD (ORCPT ); Tue, 26 Apr 2016 15:52:03 -0400 Date: Tue, 26 Apr 2016 12:51:59 -0700 From: Tony Lindgren To: Steven Rostedt Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, mingo@kernel.org, Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426195158.GR5995@atomide.com> References: <1461617335-22372-1-git-send-email-paulmck@linux.vnet.ibm.com> <20160426150031.GP5995@atomide.com> <20160426175214.GJ3715@linux.vnet.ibm.com> <20160426182939.GO5995@atomide.com> <20160426190755.GK3715@linux.vnet.ibm.com> <20160426193949.GP5995@atomide.com> <20160426154414.7bb33de4@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160426154414.7bb33de4@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt [160426 12:45]: > *Whack* *Whack* *Whack*!!! > > Signed-off-by: Steven Rostedt > --- > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index fb74dc1f7520..4fa43c02d682 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > if (--core->enable_count > 0) > return; > > - trace_clk_disable(core); > + trace_clk_disable_rcuidle(core); > > if (core->ops->disable) > core->ops->disable(core->hw); > > - trace_clk_disable_complete(core); > + trace_clk_disable_complete_rcuidle(core); > > clk_core_disable(core->parent); > } Now the mole shows up here! =============================== [ INFO: suspicious RCU usage. ] 4.6.0-rc5-next-20160426+ #1116 Not tainted ------------------------------- include/trace/events/rpm.h:95 suspicious rcu_dereference_check() usage! other info that might help us debug this: RCU used illegally from idle CPU! rcu_scheduler_active = 1, debug_locks = 0 RCU used illegally from extended quiescent state! 1 lock held by swapper/0/0: #0: (&(&dev->power.lock)->rlock){-.-...}, at: [] __rpm_callback+0x58/0x60 stack backtrace: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1116 Hardware name: Generic OMAP36xx (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xb0/0xe4) [] (dump_stack) from [] (rpm_suspend+0x580/0x768) [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) [] (__pm_runtime_suspend) from [] (omap2_gpio_prepare_for_idle+0x5c/0x70) [] (omap2_gpio_prepare_for_idle) from [] (omap_sram_idle+0x140/0x244) [] (omap_sram_idle) from [] (omap3_enter_idle_bm+0xfc/0x1ec) [] (omap3_enter_idle_bm) from [] (cpuidle_enter_state+0x80/0x3d4) [] (cpuidle_enter_state) from [] (cpu_startup_entry+0x198/0x3a0) [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8) [] (start_kernel) from [<8000807c>] (0x8000807c)