Re: [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller

Jan Glauber
2016-04-26T05:51:43Z

On Mon, Apr 25, 2016 at 11:44:29PM +0200, Wolfram Sang wrote:
> On Mon, Apr 25, 2016 at 04:33:34PM +0200, Jan Glauber wrote:
> > From: David Daney <ddaney@caviumnetworks.com>
> >
> > Use High-Level Controller (HLC) when possible. The HLC can read/write
> > up to 8 bytes and is completely optional. The most important difference
> > of the HLC is that it only requires one interrupt for a transfer
> > (up to 8 bytes) where the low-level read/write requires 2 interrupts
> > plus one interrupt per transferred byte. Since the interrupts are costly
> > using the HLC improves the performance. Also, the HLC provides improved
> > error handling.
> >
> > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
>
> Applied to for-next, thanks!
>
> I can recommend using --strict with checkpatch. It found some issues:

I thought checkpatch is always strict, but seriously, I didn't know that
option. Thanks for fixing that!

Jan

> total: 0 errors, 0 warnings, 18 checks, 427 lines checked
>
> CHECK: No space is necessary after a cast
> #327: FILE: drivers/i2c/busses/i2c-octeon.c:563:
> + ext |= (u64) msgs[0].buf[0] << SW_TWSI_IA_SHIFT;
>
> I fixed all 14 of those.
>
> CHECK: braces {} should be used on all arms of this statement
> #325: FILE: drivers/i2c/busses/i2c-octeon.c:561:
> + if (msgs[0].len == 2) {
> [...]
> + } else
> [...]
>
> and 2 of those.
>