Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework

Wolfram Sang
2016-04-25T21:29:20Z

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On Mon, Apr 25, 2016 at 04:33:31PM +0200, Jan Glauber wrote:
> Switch to the i2c bus recovery framework using generic SCL recovery.
> If this fails try to reset the hardware. The recovery is triggered
> during START on timeout of the interrupt or failure to reach
> the START / repeated-START condition.
>
> The START function is moved to xfer and while at it remove the
> xfer debug message (i2c core already provides a debug message
> for this).
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

Applied to for-next, thanks!

Fixed this checkpatch warning:

CHECK: Please don't use multiple blank lines
#32: FILE: drivers/i2c/busses/i2c-octeon.c:157:

> + return (ret) ? ret : -EAGAIN;

I'd write 'return ret ?: -EAGAIN' but this is a 'mileage varies' thing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]