From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbcDZVZ7 (ORCPT ); Tue, 26 Apr 2016 17:25:59 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:57696 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbcDZVZ5 (ORCPT ); Tue, 26 Apr 2016 17:25:57 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-omap@vger.kernel.org Date: Tue, 26 Apr 2016 14:26:30 -0700 From: "Paul E. McKenney" To: Tony Lindgren Cc: Russell King , linux-kernel@vger.kernel.org, Steven Rostedt , linux-omap@vger.kernel.org, mingo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Message-ID: <20160426212630.GV3715@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20160426193949.GP5995@atomide.com> <20160426154414.7bb33de4@gandalf.local.home> <20160426195158.GR5995@atomide.com> <20160426200613.GO3715@linux.vnet.ibm.com> <20160426201134.GA29779@linux.vnet.ibm.com> <20160426202538.GS5995@atomide.com> <20160426204148.GR3715@linux.vnet.ibm.com> <20160426204613.GT5995@atomide.com> <20160426210407.GT3715@linux.vnet.ibm.com> <20160426211259.GU5995@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160426211259.GU5995@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042621-0005-0000-0000-00002AFA320B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 02:12:59PM -0700, Tony Lindgren wrote: > * Paul E. McKenney [160426 14:08]: > > On Tue, Apr 26, 2016 at 01:46:15PM -0700, Tony Lindgren wrote: > > > * Paul E. McKenney [160426 13:42]: > > > > On Tue, Apr 26, 2016 at 01:25:39PM -0700, Tony Lindgren wrote: > > > > > * Paul E. McKenney [160426 13:12]: > > > > > > On Tue, Apr 26, 2016 at 01:06:13PM -0700, Paul E. McKenney wrote: > > > > > > > On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote: > > > > > > > > * Steven Rostedt [160426 12:45]: > > > > > > > > > *Whack* *Whack* *Whack*!!! > > > > > > > > > > > > > > > > > > Signed-off-by: Steven Rostedt > > > > > > > > > --- > > > > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > > > > > > index fb74dc1f7520..4fa43c02d682 100644 > > > > > > > > > --- a/drivers/clk/clk.c > > > > > > > > > +++ b/drivers/clk/clk.c > > > > > > > > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core) > > > > > > > > > if (--core->enable_count > 0) > > > > > > > > > return; > > > > > > > > > > > > > > > > > > - trace_clk_disable(core); > > > > > > > > > + trace_clk_disable_rcuidle(core); > > > > > > > > > > > > > > > > > > if (core->ops->disable) > > > > > > > > > core->ops->disable(core->hw); > > > > > > > > > > > > > > > > > > - trace_clk_disable_complete(core); > > > > > > > > > + trace_clk_disable_complete_rcuidle(core); > > > > > > > > > > > > > > > > > > clk_core_disable(core->parent); > > > > > > > > > } > > > > > > > > > > > > > > > > Now the mole shows up here! > > > > > > > > > > > > > > And the patch shows up here! > > > > > > > > > > > > And I bet you will need this one as well... > > > > > > > > > > OK and now the mode is coming back after a short nap during idle: > > > > > > > > Seems a bit unfair to whack it just after a short nap, but here goes! > > > > > > This mode seems pretty hard headed :) Now clk_core_enable: > > > > Nah, just a lot of heads... > > OK that does it for me. Thanks for all the mole related whacks, > please feel free to add: > > Tested-by: Tony Lindgren Done! These are at -rcu: 6eeec2b4a50c (arm: Use _rcuidle tracepoint to allow use from idle) 0efee3da3b29 (arm: Use more _rcuidle tracepoints to allow use from idle) b6cdf6d22f52 (arm: Additional _rcuidle tracepoints to allow use from idle) 70da6fb7275b (arm: Whack another event-trace-from-idle mole) 019db9102c6c (arm: Whack yet another event-trace-from-idle mole) ebcd2861ae27 (arm: Whack an expected event-trace-from-idle mole) So how would you like these handled? I would be happy to send a fresh patch series or git pull request if you would like to send them up your tree, or I can send them up my usual path. Just let me know! And I would guess that other hardware and other configurations will cause other moles to pop their heads up, but you never know. Thanx, Paul