Re: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle

Paul E. McKenney
2016-04-26T20:11:31Z

On Tue, Apr 26, 2016 at 01:06:13PM -0700, Paul E. McKenney wrote:
> On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote:
> > * Steven Rostedt <rostedt@goodmis.org> [160426 12:45]:
> > > *Whack* *Whack* *Whack*!!!
> > >
> > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > > ---
> > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > > index fb74dc1f7520..4fa43c02d682 100644
> > > --- a/drivers/clk/clk.c
> > > +++ b/drivers/clk/clk.c
> > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
> > > if (--core->enable_count > 0)
> > > return;
> > >
> > > - trace_clk_disable(core);
> > > + trace_clk_disable_rcuidle(core);
> > >
> > > if (core->ops->disable)
> > > core->ops->disable(core->hw);
> > >
> > > - trace_clk_disable_complete(core);
> > > + trace_clk_disable_complete_rcuidle(core);
> > >
> > > clk_core_disable(core->parent);
> > > }
> >
> > Now the mole shows up here!
>
> And the patch shows up here!

And I bet you will need this one as well...

Thanx, Paul

------------------------------------------------------------------------

commit 95dc0699fbaebdb507e8222257ed3b50a13093bf
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date: Tue Apr 26 13:10:21 2016 -0700

Merge with 718aeef4b4f2 (arm: Use more _rcuidle tracepoints to allow use from idle)

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index af4c38d41aff..e4c2b8fdeff3 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -549,7 +549,7 @@ static int rpm_suspend(struct device *dev, int rpmflags)
}

out:
- trace_rpm_return_int(dev, _THIS_IP_, retval);
+ trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval);

return retval;