From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.com>, Tejun Heo <tj@kernel.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org,
Byungchul Park <byungchul.park@lge.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] printk: make printk.synchronous param rw
Date: Wed, 27 Apr 2016 10:09:27 +0900 [thread overview]
Message-ID: <20160427010927.GE4782@swordfish> (raw)
In-Reply-To: <20160426141553.GJ2749@pathway.suse.cz>
Hello,
On (04/26/16 16:15), Petr Mladek wrote:
[..]
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index 89f5441..9345a29 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -2757,6 +2759,13 @@ static int __init printk_late_init(void)
> > late_initcall(printk_late_init);
> >
> > #if defined CONFIG_PRINTK
> > +/*
> > + * Prevent starting printk_kthread from start_kernel()->parse_args().
> > + * It's not possible at this stage. Instead, do it via the inticall
> ^^^^^^^^
>
> s/inticall/initcall/
geez, english is hard :(
> Otherwise, it looks fine. I like the series and keep my fingers
> crossed.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
thanks!
my system was massively Oopsing (due to kcompactd direct freepage
allocation, I suspect), OOM panicking, etc. during zsmalloc/zram
stress tests yesterday. and async printk worked fine for me. just
for note.
-ss
prev parent reply other threads:[~2016-04-27 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:52 [PATCH v12 0/3] printk: Make printk() completely async Sergey Senozhatsky
2016-04-22 13:52 ` [PATCH v12 1/3] " Sergey Senozhatsky
2016-04-26 14:13 ` Petr Mladek
2016-04-22 13:52 ` [PATCH v12 2/3] printk: Make wake_up_klogd_work_func() async Sergey Senozhatsky
2016-04-22 13:53 ` [PATCH v12 3/3] printk: make printk.synchronous param rw Sergey Senozhatsky
2016-04-23 6:56 ` Jan Kara
2016-04-23 8:26 ` Sergey Senozhatsky
2016-04-23 15:01 ` [PATCH] " Sergey Senozhatsky
2016-04-26 14:15 ` Petr Mladek
2016-04-27 1:09 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427010927.GE4782@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=byungchul.park@lge.com \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox