From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: akpm@linux-foundation.org
Cc: ddstreet@ieee.org, dan.streetman@canonical.com,
yuzhao@google.com, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: + mm-zswap-use-workqueue-to-destroy-pool.patch added to -mm tree
Date: Wed, 27 Apr 2016 14:40:04 +0900 [thread overview]
Message-ID: <20160427054004.GA7601@swordfish> (raw)
In-Reply-To: <571fff47.caCgiy6gTD/vCFnv%akpm@linux-foundation.org>
Hello,
On (04/26/16 16:52), akpm@linux-foundation.org wrote:
[..]
> -static void __zswap_pool_release(struct rcu_head *head)
> +static void __zswap_pool_release(struct work_struct *work)
> {
> - struct zswap_pool *pool = container_of(head, typeof(*pool), rcu_head);
> + struct zswap_pool *pool = container_of(work, typeof(*pool), work);
> +
> + synchronize_rcu();
>
> /* nobody should have been able to get a kref... */
> WARN_ON(kref_get_unless_zero(&pool->kref));
> @@ -674,7 +676,9 @@ static void __zswap_pool_empty(struct kr
> WARN_ON(pool == zswap_pool_current());
>
> list_del_rcu(&pool->list);
> - call_rcu(&pool->rcu_head, __zswap_pool_release);
> +
> + INIT_WORK(&pool->work, __zswap_pool_release);
> + schedule_work(&pool->work);
>
> spin_unlock(&zswap_pools_lock);
> }
> _
>
> Patches currently in -mm which might be from ddstreet@ieee.org are
>
> mm-zpool-use-workqueue-for-zpool_destroy.patch
> mm-zswap-use-workqueue-to-destroy-pool.patch
I think only mm-zswap-use-workqueue-to-destroy-pool.patch is
needed.
-ss
next parent reply other threads:[~2016-04-27 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <571fff47.caCgiy6gTD/vCFnv%akpm@linux-foundation.org>
2016-04-27 5:40 ` Sergey Senozhatsky [this message]
2016-04-27 8:15 ` + mm-zswap-use-workqueue-to-destroy-pool.patch added to -mm tree Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427054004.GA7601@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.streetman@canonical.com \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox