From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818AbcD0KHV (ORCPT ); Wed, 27 Apr 2016 06:07:21 -0400 Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:44964 "EHLO outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753358AbcD0KHT (ORCPT ); Wed, 27 Apr 2016 06:07:19 -0400 Date: Wed, 27 Apr 2016 11:07:13 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Jesper Dangaard Brouer , Linux-MM , LKML Subject: Re: [PATCH 23/28] mm, page_alloc: Check multiple page fields with a single branch Message-ID: <20160427100713.GG2858@techsingularity.net> References: <1460710760-32601-1-git-send-email-mgorman@techsingularity.net> <1460711275-1130-1-git-send-email-mgorman@techsingularity.net> <1460711275-1130-11-git-send-email-mgorman@techsingularity.net> <571FB66E.80306@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <571FB66E.80306@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 08:41:50PM +0200, Vlastimil Babka wrote: > On 04/15/2016 11:07 AM, Mel Gorman wrote: > >Signed-off-by: Mel Gorman > > Acked-by: Vlastimil Babka > > I wonder, would it be just too ugly to add +1 to > atomic_read(&page->_mapcount) and OR it with the rest for a truly single > branch? > Interesting thought. I'm not going to do it as a fix but when I'm doing the next round of page allocator material, I'll add it to the pile for evaluation. -- Mel Gorman SUSE Labs