From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbcD0MaP (ORCPT ); Wed, 27 Apr 2016 08:30:15 -0400 Received: from outbound-smtp11.blacknight.com ([46.22.139.16]:51949 "EHLO outbound-smtp11.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbcD0MaN (ORCPT ); Wed, 27 Apr 2016 08:30:13 -0400 Date: Wed, 27 Apr 2016 13:30:09 +0100 From: Mel Gorman To: Andrew Morton Cc: Vlastimil Babka , Jesper Dangaard Brouer , Linux-MM , LKML Subject: Re: [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist iterator -fix Message-ID: <20160427123009.GH2858@techsingularity.net> References: <1461759885-17163-1-git-send-email-mgorman@techsingularity.net> <1461759885-17163-3-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1461759885-17163-3-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2016 at 01:24:43PM +0100, Mel Gorman wrote: > Vlastimil Babka pointed out that the nodes allowed by a cpuset are not > reread if the nodemask changes during an allocation. This potentially > allows an unnecessary page allocation failure. Moving the retry_cpuset > label is insufficient but rereading the nodemask before retrying addresses > the problem. > > This is a fix to the mmotm patch > mm-page_alloc-inline-the-fast-path-of-the-zonelist-iterator.patch . > > Suggested-by: Vlastimil Babka > Signed-off-by: Mel Gorman And this is wrong :( . I'll think again. -- Mel Gorman SUSE Labs