From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbcD0Mll (ORCPT ); Wed, 27 Apr 2016 08:41:41 -0400 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:34242 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbcD0Mlk (ORCPT ); Wed, 27 Apr 2016 08:41:40 -0400 Date: Wed, 27 Apr 2016 13:41:36 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jesper Dangaard Brouer Subject: Re: [PATCH 2/3] mm, page_alloc: pull out side effects from free_pages_check Message-ID: <20160427124136.GJ2858@techsingularity.net> References: <5720A987.7060507@suse.cz> <1461758476-450-1-git-send-email-vbabka@suse.cz> <1461758476-450-2-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1461758476-450-2-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2016 at 02:01:15PM +0200, Vlastimil Babka wrote: > Check without side-effects should be easier to maintain. It also removes the > duplicated cpupid and flags reset done in !DEBUG_VM variant of both > free_pcp_prepare() and then bulkfree_pcp_prepare(). Finally, it enables > the next patch. > Hmm, now the cpuid and flags reset is done in multiple places. While this is potentially faster, it goes against the comment "I don't like the duplicated code in free_pcp_prepare() from maintenance perspective". -- Mel Gorman SUSE Labs