Re: [PATCH V10 2/6] mfd: max77620: add core driver for MAX77620/MAX20024

Thierry Reding
2016-04-27T15:06:20Z

[-- Attachment #1: Type: text/plain, Size: 2538 bytes --]

On Wed, Mar 30, 2016 at 07:59:44PM +0530, Laxman Dewangan wrote:
> MAX77620/MAX20024 are Power Management IC from the MAXIM.
> It supports RTC, multiple GPIOs, multiple DCDC and LDOs,
> watchdog, clock etc.
>
> Add MFD drier to provides common support for accessing the
> device; additional drivers is developed on respected subsystem
> in order to use the functionality of the device.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
> Changes from V1:
> - Code cleanups per review from V1.
> - Move register acccess APIs from header to c file.
> - Remove some of non required variable, remove duplication in error message
> and simplify some of function implementation.
> - Register RTC driver such that it can get the regmap handle form parent device
>
> Changes from V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - Drop RTC driver and its i2c client registration.
>
> Changes from V3:
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
>
> Changes from V4:
> - Take care of fps nodes.
> - Drop the battery charger and low battery binding and related code as
> it need to go on power driver.
>
> Changes from V5:
> -None
>
> Changes from V6:
> - Taken care of Lee's comment like used defines for irqs, remove max77620
> register accesss abstractions, remove DTof module and use ID table only,
> reduce the copyright lines.
> - Drop configuration for hard power off time chnage as it will be in
> power driver.
> - Use direct regmap from all drivers instead of using abstractions.
> - This depends on patch
>
> Change from V7:
> - Use MFD defines for making mfd cells.
> - Use new property name.
>
> Changes from V8:
> - Remove the usage of MFD defines. Remove mutex_config as not needed.
>
> Changes from V9:
> - Use the devm_regmap_add_irq_chip() for irq registration.
>
> drivers/mfd/Kconfig | 15 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/max77620.c | 544 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/max77620.h | 337 +++++++++++++++++++++++++++
> 4 files changed, 897 insertions(+)
> create mode 100644 drivers/mfd/max77620.c
> create mode 100644 include/linux/mfd/max77620.h

Lee,

Were you going to pick this up along with the corresponding DT bindings?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]