From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbcD0Pb1 (ORCPT ); Wed, 27 Apr 2016 11:31:27 -0400 Received: from outbound-smtp11.blacknight.com ([46.22.139.16]:32822 "EHLO outbound-smtp11.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753145AbcD0Pb0 (ORCPT ); Wed, 27 Apr 2016 11:31:26 -0400 Date: Wed, 27 Apr 2016 16:31:21 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Jesper Dangaard Brouer , Linux-MM , LKML Subject: Re: [PATCH 28/28] mm, page_alloc: Defer debugging checks of pages allocated from the PCP Message-ID: <20160427153121.GK2858@techsingularity.net> References: <1460710760-32601-1-git-send-email-mgorman@techsingularity.net> <1460711275-1130-1-git-send-email-mgorman@techsingularity.net> <1460711275-1130-16-git-send-email-mgorman@techsingularity.net> <5720C753.2000804@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5720C753.2000804@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2016 at 04:06:11PM +0200, Vlastimil Babka wrote: > From afdefd87f2d8d07cba4bd2a2f3531dc8bb0b7a19 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Wed, 27 Apr 2016 15:47:29 +0200 > Subject: [PATCH] mm, page_alloc: uninline the bad page part of > check_new_page() > > Bad pages should be rare so the code handling them doesn't need to be inline > for performance reasons. Put it to separate function which returns void. > This also assumes that the initial page_expected_state() result will match the > result of the thorough check, i.e. the page doesn't become "good" in the > meanwhile. This matches the same expectations already in place in > free_pages_check(). > > !DEBUG_VM bloat-o-meter: > > add/remove: 1/0 grow/shrink: 0/1 up/down: 134/-274 (-140) > function old new delta > check_new_page_bad - 134 +134 > get_page_from_freelist 3468 3194 -274 > > Signed-off-by: Vlastimil Babka Acked-by: Mel Gorman Andrew, if you pick up v2 of of the follow-up series then can you also add this patch on top if it's convenient please? -- Mel Gorman SUSE Labs