From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbcD0QHt (ORCPT ); Wed, 27 Apr 2016 12:07:49 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35156 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbcD0QHr (ORCPT ); Wed, 27 Apr 2016 12:07:47 -0400 Date: Wed, 27 Apr 2016 17:07:46 +0100 From: Lee Jones To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , linux-pm@vger.kernel.org Subject: Re: [PATCH] cpufreq: st: enable selective initialization based on the platform Message-ID: <20160427160746.GG4892@dell> References: <1461757227-22381-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461757227-22381-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Apr 2016, Sudeep Holla wrote: > The sti-cpufreq does unconditional registration of the cpufreq-dt driver > which causes issue on an multi-platform build. For example, on Vexpress > TC2 platform, we get the following error on boot: > > cpu cpu0: OPP-v2 not supported > cpu cpu0: Not doing voltage scaling > cpu: dev_pm_opp_of_cpumask_add_table: couldn't find opp table > for cpu:0, -19 > cpu cpu0: dev_pm_opp_get_max_volt_latency: Invalid regulator (-6) > ... > arm_big_little: bL_cpufreq_register: Failed registering platform driver: > vexpress-spc, err: -17 > > The actual driver fails to initialise as cpufreq-dt is probed > successfully, which is incorrect. This issue can happen to any platform > not using cpufreq-dt in a multi-platform build. Ah yes. One of the pitfalls of not requiring platform registration. > This patch adds a check to do selective initialization of the driver. > > Cc: Lee Jones > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux-pm@vger.kernel.org > Fixes: ab0ea257fc58 ("cpufreq: st: Provide runtime initialised driver for ST's platforms") > Signed-off-by: Sudeep Holla > --- > drivers/cpufreq/sti-cpufreq.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c > index a9c659f58974..5fce58712a97 100644 > --- a/drivers/cpufreq/sti-cpufreq.c > +++ b/drivers/cpufreq/sti-cpufreq.c > @@ -259,6 +259,10 @@ static int sti_cpufreq_init(void) > { > int ret; > > + if ((!of_machine_is_compatible("st,stih407-b2120")) && > + (!of_machine_is_compatible("st,stih407"))) > + return -ENODEV; You need to check for "st,stih407" and "st,stih410". > ddata.cpu = get_cpu_device(0); > if (!ddata.cpu) { > dev_err(ddata.cpu, "Failed to get device for CPU0\n"); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog