Re: [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860

Jan Glauber
2016-04-27T09:37:31Z

On Tue, Apr 26, 2016 at 11:17:59PM +0200, Wolfram Sang wrote:
> On Mon, Apr 25, 2016 at 04:33:38PM +0200, Jan Glauber wrote:
> > From: David Daney <david.daney@cavium.com>
> >
> > CN3860 does not interrupt the CPU when the i2c status changes. If
> > we get a timeout, and see the status has in fact changed, we know we
> > have this problem, and drop back to polling.
> >
> > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
>
> My code checkers say something:
>
> CHECKPATCH
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> #37: FILE: drivers/i2c/busses/i2c-octeon.c:390:
> + udelay(50);
>
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> #70: FILE: drivers/i2c/busses/i2c-octeon.c:529:
> + udelay(50);
>
> Dunno if you want to change that? Seems reasonable to me. Also:

Yes, makes sense.

> SMATCH
> drivers/i2c/busses/i2c-octeon.c:544 octeon_i2c_hlc_wait() warn: inconsistent indenting
>
> This is true as well.
>

OK, I'll reply with an updated patch.