From: Baoquan He <bhe@redhat.com>
To: Xiong Zhou <jencce.kernel@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH trivial] scripts/prune-kernel: remove kdump images
Date: Thu, 28 Apr 2016 13:52:17 +0800 [thread overview]
Message-ID: <20160428055217.GC3359@x1.redhat.com> (raw)
In-Reply-To: <CADJHv_viGLzdvy_VmrBpsOdGhP+X8qHxtJG7yBUnW0MTJX5pqw@mail.gmail.com>
On 03/07/16 at 03:56pm, Xiong Zhou wrote:
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> ---
> scripts/prune-kernel | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/prune-kernel b/scripts/prune-kernel
> index ab5034e..9c67be2 100755
> --- a/scripts/prune-kernel
> +++ b/scripts/prune-kernel
> @@ -14,7 +14,7 @@ do
> echo "removing $f"
> rm -f "/boot/initramfs-$f.img" "/boot/System.map-$f"
> rm -f "/boot/vmlinuz-$f" "/boot/config-$f"
> - rm -rf "/lib/modules/$f"
> + rm -rf "/lib/modules/$f" "/boot/initramfs-${f}kdump.img"
It makes sense to remove kdump initramfs file if its related kernel and
modules directory have been removed. I like this fix, maybe it's better
to add at least one line of description to tell why it deserves removal.
Thanks
Baoquan
prev parent reply other threads:[~2016-04-28 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 7:56 [PATCH trivial] scripts/prune-kernel: remove kdump images Xiong Zhou
2016-04-26 1:31 ` Xiong Zhou
2016-04-28 5:52 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428055217.GC3359@x1.redhat.com \
--to=bhe@redhat.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox