public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH trivial] scripts/prune-kernel: remove kdump images
@ 2016-03-07  7:56 Xiong Zhou
  2016-04-26  1:31 ` Xiong Zhou
  2016-04-28  5:52 ` Baoquan He
  0 siblings, 2 replies; 3+ messages in thread
From: Xiong Zhou @ 2016-03-07  7:56 UTC (permalink / raw)
  To: linux-kernel@vger.kernel.org, Jiri Kosina

Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
---
 scripts/prune-kernel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/prune-kernel b/scripts/prune-kernel
index ab5034e..9c67be2 100755
--- a/scripts/prune-kernel
+++ b/scripts/prune-kernel
@@ -14,7 +14,7 @@ do
                 echo "removing $f"
                 rm -f "/boot/initramfs-$f.img" "/boot/System.map-$f"
                 rm -f "/boot/vmlinuz-$f"   "/boot/config-$f"
-                rm -rf "/lib/modules/$f"
+                rm -rf "/lib/modules/$f" "/boot/initramfs-${f}kdump.img"
                 new-kernel-pkg --remove $f
         fi
 done
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH trivial] scripts/prune-kernel: remove kdump images
  2016-03-07  7:56 [PATCH trivial] scripts/prune-kernel: remove kdump images Xiong Zhou
@ 2016-04-26  1:31 ` Xiong Zhou
  2016-04-28  5:52 ` Baoquan He
  1 sibling, 0 replies; 3+ messages in thread
From: Xiong Zhou @ 2016-04-26  1:31 UTC (permalink / raw)
  To: linux-kernel@vger.kernel.org, Jiri Kosina

ping ?

On Mon, Mar 7, 2016 at 3:56 PM, Xiong Zhou <jencce.kernel@gmail.com> wrote:
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> ---
>  scripts/prune-kernel | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/prune-kernel b/scripts/prune-kernel
> index ab5034e..9c67be2 100755
> --- a/scripts/prune-kernel
> +++ b/scripts/prune-kernel
> @@ -14,7 +14,7 @@ do
>                  echo "removing $f"
>                  rm -f "/boot/initramfs-$f.img" "/boot/System.map-$f"
>                  rm -f "/boot/vmlinuz-$f"   "/boot/config-$f"
> -                rm -rf "/lib/modules/$f"
> +                rm -rf "/lib/modules/$f" "/boot/initramfs-${f}kdump.img"
>                  new-kernel-pkg --remove $f
>          fi
>  done
> --
> 2.5.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH trivial] scripts/prune-kernel: remove kdump images
  2016-03-07  7:56 [PATCH trivial] scripts/prune-kernel: remove kdump images Xiong Zhou
  2016-04-26  1:31 ` Xiong Zhou
@ 2016-04-28  5:52 ` Baoquan He
  1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2016-04-28  5:52 UTC (permalink / raw)
  To: Xiong Zhou; +Cc: linux-kernel@vger.kernel.org, Jiri Kosina

On 03/07/16 at 03:56pm, Xiong Zhou wrote:
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> ---
>  scripts/prune-kernel | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/prune-kernel b/scripts/prune-kernel
> index ab5034e..9c67be2 100755
> --- a/scripts/prune-kernel
> +++ b/scripts/prune-kernel
> @@ -14,7 +14,7 @@ do
>                  echo "removing $f"
>                  rm -f "/boot/initramfs-$f.img" "/boot/System.map-$f"
>                  rm -f "/boot/vmlinuz-$f"   "/boot/config-$f"
> -                rm -rf "/lib/modules/$f"
> +                rm -rf "/lib/modules/$f" "/boot/initramfs-${f}kdump.img"

It makes sense to remove kdump initramfs file if its related kernel and
modules directory have been removed. I like this fix, maybe it's better
to add at least one line of description to tell why it deserves removal.

Thanks
Baoquan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-28  5:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07  7:56 [PATCH trivial] scripts/prune-kernel: remove kdump images Xiong Zhou
2016-04-26  1:31 ` Xiong Zhou
2016-04-28  5:52 ` Baoquan He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox