From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbcD1ItK (ORCPT ); Thu, 28 Apr 2016 04:49:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58435 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbcD1ItG (ORCPT ); Thu, 28 Apr 2016 04:49:06 -0400 Date: Thu, 28 Apr 2016 10:49:03 +0200 From: Jiri Olsa To: Chris Phlipot Cc: adrian.hunter@intel.com, jolsa@kernel.org, acme@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] perf tools: fix incorrect ordering of callchain entries Message-ID: <20160428084903.GC24122@krava> References: <1461831551-12213-1-git-send-email-cphlipot0@gmail.com> <1461831551-12213-2-git-send-email-cphlipot0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461831551-12213-2-git-send-email-cphlipot0@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 28 Apr 2016 08:49:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2016 at 01:19:06AM -0700, Chris Phlipot wrote: > The existing implementation of thread__resolve_callchain, under certain > circumstances, can assemble callchain entries in the incorrect order. SNIP > 0x558f2a04c774 > 0x558f2a04dded > rand > __random > ret_from_intr > do_IRQ > handle_irq > handle_edge_irq > handle_irq_event > handle_irq_event_percpu > gen8_irq_handler > > Signed-off-by: Chris Phlipot for this patch Acked-by: Jiri Olsa can't really ack the rest of the patchset, but it looks good to me thanks, jirka