From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Robin van der Gracht <robin@protonic.nl>,
"arm@kernel.org" <arm@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Miguel Ojeda Sandonis <maxextreme@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [GIT PULL] move ARM LCD display driver to auxdisplay
Date: Thu, 28 Apr 2016 11:26:08 +0200 [thread overview]
Message-ID: <20160428092608.GE17159@lukather> (raw)
In-Reply-To: <CACRpkdb=s5onVa7qND9nFUtYPw5H-Hdr7Ja5o3=-9+wxghHekQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote:
> On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
> >> Hi ARM SoC guys,
> >>
> >> these two patches move the ARM character LCD driver from
> >> misc drivers to the auxdisplay subsystem where it belongs and
> >> updates the defconfig for the RealView accordingly.
> >>
> >> Please pull it into some cleanup branch in the ARM SoC
> >> tree.
> >>
> >> I tried to get some ACK from the auxdisplay maintainer but no
> >> reaction.
> >
> > Auxdisplay is not a new framework, but rather a very old one.
> >
> > It got introduced in 2.6.21, and only received a couple of drivers
> > since.
>
> Small problem for me, but Robin is submitting a brand new
> auxdisplay driver:
> http://marc.info/?l=linux-kernel&m=146001950512999&w=2
> http://marc.info/?l=linux-kernel&m=146001988013230&w=2
My understanding is that Tomi doesn't want any new fbdev drivers, so
I'm not sure this is the right place for those patches.
> > It seems to be quite redundant with fbdev deferred_io, which itself is
> > almost deprecated these days.
>
> That is a valid argument for moving cfag12864b* out to
> drivers/video/* I guess, but it has nothing to do with this
> driver whatsoever.
>
> This driver has nothing to do with fbdev. Nothing at all.
> It so not connected to any framebuffer.
>
> This driver gets moved to auxdisplay to match the existing
> LCD driver in drivers/auxdisplay/ks0108.c which is a similar
> hardware, driving an LCD that likewise has nothing to do
> with fbdev.
My bad, I thought all auxdisplay drivers were fbdev ones, but I was
wrong, obviously. And now, I don't really know what auxdisplay is
about anymore :)
Still, moving it to a "framework" that has been inactive for so long
(and you even mention it in your PR) doesn't seem like the right move.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-28 9:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 9:43 [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij
2016-04-25 11:57 ` Maxime Ripard
2016-04-25 22:18 ` Arnd Bergmann
2016-04-26 10:41 ` Linus Walleij
2016-04-28 9:26 ` Maxime Ripard [this message]
2016-04-29 7:49 ` Linus Walleij
2016-04-29 14:53 ` Tomi Valkeinen
2016-05-09 7:06 ` Robin van der Gracht
2016-05-09 13:19 ` Linus Walleij
2016-05-09 14:17 ` Robin van der Gracht
2016-05-09 14:27 ` Linus Walleij
2016-05-10 7:10 ` Greg KH
2016-05-11 7:46 ` Robin van der Gracht
2016-05-11 8:34 ` Greg KH
2016-05-12 10:25 ` Robin van der Gracht
2016-05-18 14:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428092608.GE17159@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arm@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxextreme@gmail.com \
--cc=robin@protonic.nl \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox