From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbcD1J02 (ORCPT ); Thu, 28 Apr 2016 05:26:28 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55712 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752756AbcD1J0Z (ORCPT ); Thu, 28 Apr 2016 05:26:25 -0400 Date: Thu, 28 Apr 2016 11:26:08 +0200 From: Maxime Ripard To: Linus Walleij Cc: Robin van der Gracht , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Miguel Ojeda Sandonis , Tomi Valkeinen Subject: Re: [GIT PULL] move ARM LCD display driver to auxdisplay Message-ID: <20160428092608.GE17159@lukather> References: <20160425115758.GA4874@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xaMk4Io5JJdpkLEb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xaMk4Io5JJdpkLEb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote: > On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard > wrote: > > On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote: > >> Hi ARM SoC guys, > >> > >> these two patches move the ARM character LCD driver from > >> misc drivers to the auxdisplay subsystem where it belongs and > >> updates the defconfig for the RealView accordingly. > >> > >> Please pull it into some cleanup branch in the ARM SoC > >> tree. > >> > >> I tried to get some ACK from the auxdisplay maintainer but no > >> reaction. > > > > Auxdisplay is not a new framework, but rather a very old one. > > > > It got introduced in 2.6.21, and only received a couple of drivers > > since. >=20 > Small problem for me, but Robin is submitting a brand new > auxdisplay driver: > http://marc.info/?l=3Dlinux-kernel&m=3D146001950512999&w=3D2 > http://marc.info/?l=3Dlinux-kernel&m=3D146001988013230&w=3D2 My understanding is that Tomi doesn't want any new fbdev drivers, so I'm not sure this is the right place for those patches. > > It seems to be quite redundant with fbdev deferred_io, which itself is > > almost deprecated these days. >=20 > That is a valid argument for moving cfag12864b* out to > drivers/video/* I guess, but it has nothing to do with this > driver whatsoever. >=20 > This driver has nothing to do with fbdev. Nothing at all. > It so not connected to any framebuffer. >=20 > This driver gets moved to auxdisplay to match the existing > LCD driver in drivers/auxdisplay/ks0108.c which is a similar > hardware, driving an LCD that likewise has nothing to do > with fbdev. My bad, I thought all auxdisplay drivers were fbdev ones, but I was wrong, obviously. And now, I don't really know what auxdisplay is about anymore :) Still, moving it to a "framework" that has been inactive for so long (and you even mention it in your PR) doesn't seem like the right move. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --xaMk4Io5JJdpkLEb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXIdcwAAoJEBx+YmzsjxAgGJ8QAKusOXGXWsfQbAWg2moYl4Ea 70bl1K/6rqWVDseaH7RfWNAptTlrgfTkzPzGYhZP41tsKgUddzrZSvpdmr5dKyeh aOVAlTDCv50Zt/2Sjv2sbww6tMkqvlmTliFNI+Ufx4kQvJRmXBDNATwkbPe6Xzt/ UuroRFq/YtmnYedLT1yFSM4YFkxHWALNd5nHnCN/XiZWMTOWO2lO1XgpPIrvRmug tafpUqLc3MwTRnBA6J/9IC5jw2Qym8RybjHArr0hUdtzDFAeJdQZ6Utdq6ew286y kaB2T21NRna2FFtHSfO9O6IJc84bWJolqnq9MQKwQgEPl8+I14hcER3HqHncGqM5 v3upJzZlDdeuypzm9TgST1U5fyDPoAa1wKZXTU0mZoKDmnFohkjRHx6BUEmT1rlV cmYE58qveM1iWfNmbYp0O/7f5+sN5MMdn4BFuRsaEdQdN7K1NfGsnnr1v2kgaWFZ 1PBxNt4vfqCtaZJxYEraOToo83FhLD2lfptvkpdDY+6N13FwgfWpSKqtve9Iq/Gp B0f9PJBHw4NCr6yjqcM7SrMU9mth1k97aEi97JkkkFe2Jvb4dih8Ifjtm49mrk/5 DzX6G7F7ml8XoULFVAfJtJRLtT8r4XsGDx9AHbBlxlB2FZuTcg5Dpb870DqjCElb 62+lo7HKPWF9JpWupX7g =5mrz -----END PGP SIGNATURE----- --xaMk4Io5JJdpkLEb--