From: Jiri Olsa <jolsa@redhat.com>
To: Kyeongmin Cho <korea.drzix@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/2] perf report: Find lib path correctly for gtk option
Date: Thu, 28 Apr 2016 16:07:51 +0200 [thread overview]
Message-ID: <20160428140751.GA17161@krava> (raw)
In-Reply-To: <1461848401-32125-1-git-send-email-korea.drzix@gmail.com>
On Thu, Apr 28, 2016 at 10:00:00PM +0900, Kyeongmin Cho wrote:
> When "perf report --gtk", it cannot find libperf-gtk.so.
> This patch apply correct path of LIBDIR to setup_gtk_browser().
hi,
could you please add to changelog some more info
about why the case change is actualy needed?
thanks,
jirka
>
> Signed-off-by: Kyeongmin Cho <korea.drzix@gmail.com>
> ---
> tools/perf/config/Makefile | 2 +-
> tools/perf/ui/Build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index f7d7f5a..d96b185 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -794,7 +794,7 @@ $(call detected_var,prefix_SQ)
> $(call detected_var,perfexecdir_SQ)
> $(call detected_var,tipdir_SQ)
> $(call detected_var,srcdir_SQ)
> -$(call detected_var,LIBDIR)
> +$(call detected_var,libdir)
> $(call detected_var,GTK_CFLAGS)
> $(call detected_var,PERL_EMBED_CCOPTS)
> $(call detected_var,PYTHON_EMBED_CCOPTS)
> diff --git a/tools/perf/ui/Build b/tools/perf/ui/Build
> index 0a73538..cd3f92f0 100644
> --- a/tools/perf/ui/Build
> +++ b/tools/perf/ui/Build
> @@ -5,7 +5,7 @@ libperf-y += util.o
> libperf-y += hist.o
> libperf-y += stdio/hist.o
>
> -CFLAGS_setup.o += -DLIBDIR="BUILD_STR($(LIBDIR))"
> +CFLAGS_setup.o += -DLIBDIR="BUILD_STR($(libdir))"
>
> libperf-$(CONFIG_SLANG) += browser.o
> libperf-$(CONFIG_SLANG) += browsers/
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-04-28 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 13:00 [PATCH 1/2] perf report: Find lib path correctly for gtk option Kyeongmin Cho
2016-04-28 13:00 ` [PATCH 2/2] perf report: Add gcc option '-rdynamic' to define symbol callchain_param Kyeongmin Cho
2016-04-28 14:12 ` Jiri Olsa
2016-04-28 14:49 ` Kyeongmin Cho
2016-05-01 15:44 ` Jiri Olsa
2016-04-28 15:26 ` Arnaldo Carvalho de Melo
2016-04-28 14:07 ` Jiri Olsa [this message]
2016-04-28 14:35 ` [PATCH 1/2] perf report: Find lib path correctly for gtk option drzix
2016-04-29 11:50 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428140751.GA17161@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=korea.drzix@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox