From: Andrew Lunn <andrew@lunn.ch>
To: Nathan Sullivan <nathan.sullivan@ni.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v2] net: macb: do not scan PHYs manually
Date: Thu, 28 Apr 2016 20:59:32 +0200 [thread overview]
Message-ID: <20160428185932.GU29024@lunn.ch> (raw)
In-Reply-To: <20160428185527.GA8851@nathan3500-linux-VM>
On Thu, Apr 28, 2016 at 01:55:27PM -0500, Nathan Sullivan wrote:
> On Thu, Apr 28, 2016 at 08:43:03PM +0200, Andrew Lunn wrote:
> > > I agree that is a valid fix for AT91, however it won't solve our problem, since
> > > we have no children on the second ethernet MAC in our devices' device trees. I'm
> > > starting to feel like our second MAC shouldn't even really register the MDIO bus
> > > since it isn't being used - maybe adding a DT property to not have a bus is a
> > > better option?
> >
> > status = "disabled"
> >
> > would be the unusual way.
> >
> > Andrew
>
> Oh, sorry, I meant we use both MACs on Zynq, however the PHYs are on the MDIO
> bus of the first MAC. So, the second MAC is used for ethernet but not for MDIO,
> and so it does not have any PHYs under its DT node. It would be nice if there
> were a way to tell macb not to bother with MDIO for the second MAC, since that's
> handled by the first MAC.
Yes, exactly, add support for status = "disabled" in the mdio node.
> I guess a good longer-term solution to all these problems would be to treat the
> MAC and MDIO as seperate devices, like davinci seems to be doing.
A few others do this as well, e.g. most Marvell devices.
Andrew
next prev parent reply other threads:[~2016-04-28 18:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 14:46 [PATCH v2] net: macb: do not scan PHYs manually Nathan Sullivan
2016-04-28 15:44 ` Nicolas Ferre
2016-04-28 15:55 ` Nathan Sullivan
2016-04-28 16:32 ` Andrew Lunn
2016-04-28 17:56 ` Nathan Sullivan
2016-04-28 18:43 ` Andrew Lunn
2016-04-28 18:55 ` Nathan Sullivan
2016-04-28 18:59 ` Andrew Lunn [this message]
2016-04-28 20:03 ` Florian Fainelli
2016-04-28 20:10 ` Andrew Lunn
2016-04-28 21:03 ` Josh Cartwright
2016-04-28 21:23 ` Andrew Lunn
2016-04-29 0:34 ` Josh Cartwright
2016-04-29 12:25 ` Josh Cartwright
2016-04-29 12:40 ` Nicolas Ferre
2016-04-29 12:56 ` Andrew Lunn
2016-05-02 18:36 ` Josh Cartwright
2016-05-02 19:08 ` Florian Fainelli
2016-05-02 19:38 ` Josh Cartwright
2016-04-29 12:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428185932.GU29024@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.belloni@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox