From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbcD1S7i (ORCPT ); Thu, 28 Apr 2016 14:59:38 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:51955 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcD1S7g (ORCPT ); Thu, 28 Apr 2016 14:59:36 -0400 Date: Thu, 28 Apr 2016 20:59:32 +0200 From: Andrew Lunn To: Nathan Sullivan Cc: Nicolas Ferre , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Alexandre Belloni Subject: Re: [PATCH v2] net: macb: do not scan PHYs manually Message-ID: <20160428185932.GU29024@lunn.ch> References: <1461854802-8142-1-git-send-email-nathan.sullivan@ni.com> <57222FCE.8050407@atmel.com> <20160428155556.GA8333@nathan3500-linux-VM> <20160428163207.GP29024@lunn.ch> <20160428175619.GA8791@nathan3500-linux-VM> <20160428184303.GR29024@lunn.ch> <20160428185527.GA8851@nathan3500-linux-VM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160428185527.GA8851@nathan3500-linux-VM> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2016 at 01:55:27PM -0500, Nathan Sullivan wrote: > On Thu, Apr 28, 2016 at 08:43:03PM +0200, Andrew Lunn wrote: > > > I agree that is a valid fix for AT91, however it won't solve our problem, since > > > we have no children on the second ethernet MAC in our devices' device trees. I'm > > > starting to feel like our second MAC shouldn't even really register the MDIO bus > > > since it isn't being used - maybe adding a DT property to not have a bus is a > > > better option? > > > > status = "disabled" > > > > would be the unusual way. > > > > Andrew > > Oh, sorry, I meant we use both MACs on Zynq, however the PHYs are on the MDIO > bus of the first MAC. So, the second MAC is used for ethernet but not for MDIO, > and so it does not have any PHYs under its DT node. It would be nice if there > were a way to tell macb not to bother with MDIO for the second MAC, since that's > handled by the first MAC. Yes, exactly, add support for status = "disabled" in the mdio node. > I guess a good longer-term solution to all these problems would be to treat the > MAC and MDIO as seperate devices, like davinci seems to be doing. A few others do this as well, e.g. most Marvell devices. Andrew