From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbcD1XVI (ORCPT ); Thu, 28 Apr 2016 19:21:08 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52633 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbcD1XVG (ORCPT ); Thu, 28 Apr 2016 19:21:06 -0400 Date: Fri, 29 Apr 2016 01:20:58 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, davem@davemloft.net, nathan.sullivan@ni.com, nicolas.ferre@atmel.com, Rob Herring , Frank Rowand , Grant Likely , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" , open list Subject: Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is available Message-ID: <20160428232058.GC17679@lunn.ch> References: <1461880510-27132-1-git-send-email-f.fainelli@gmail.com> <20160428221211.GE12753@lunn.ch> <572298D2.3060809@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <572298D2.3060809@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Fair enough, I will submit something after re-spining this patch to use > -ENODEV, which I agree is a better return code. Did you want me to > remove that blurb from the commit message? Blurb looks good. More blurb is better than less... Andrew