From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbcD1X3O (ORCPT ); Thu, 28 Apr 2016 19:29:14 -0400 Received: from mail.kernel.org ([198.145.29.136]:38790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbcD1X3N (ORCPT ); Thu, 28 Apr 2016 19:29:13 -0400 Date: Thu, 28 Apr 2016 16:29:09 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] f2fs: fix to clear private data in page Message-ID: <20160428232909.GA41124@jaegeuk.gateway> References: <572228AC.30109@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <572228AC.30109@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, Could you check your email setting? All the patches are corrupted, as git am says. Thanks, On Thu, Apr 28, 2016 at 11:13:48PM +0800, Chao Yu wrote: > From: Chao Yu > > Private data in page should be removed during ->releasepage or > ->invalidatepage, otherwise garbage data would be remained in that page. > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 38ce5d6..888f178 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int > offset, > if (IS_ATOMIC_WRITTEN_PAGE(page)) > return; > > + set_page_private(page, 0); > ClearPagePrivate(page); > } > > @@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait) > if (IS_ATOMIC_WRITTEN_PAGE(page)) > return 0; > > + set_page_private(page, 0); > ClearPagePrivate(page); > return 1; > } > -- > 2.7.2