[PATCH] staging: rts5208: Avoid multiple assignment in one line

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] staging: rts5208: Avoid multiple assignment in one line
@ 2016-04-29  5:30 Manav Batra
  2016-04-29  5:38 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Manav Batra @ 2016-04-29  5:30 UTC (permalink / raw)
  To: gregkh, devel, linux-kernel

Signed-off-by: Manav Batra <batmanav10@gmail.com>
---
 drivers/staging/rts5208/rtsx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 25d095a..77c2580 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -105,13 +105,13 @@ static int slave_configure(struct scsi_device *sdev)
 	 * the actual value or the modified one, depending on where the
 	 * data comes from.
 	 */
-	if (sdev->scsi_level < SCSI_2)
-		sdev->scsi_level = sdev->sdev_target->scsi_level = SCSI_2;
-
+	if (sdev->scsi_level < SCSI_2) {
+		sdev->scsi_level  = SCSI_2;
+		sdev->sdev_target->scsi_level = SCSI_2;
+	}
 	return 0;
 }
 
-
 /***********************************************************************
  * /proc/scsi/ functions
  ***********************************************************************/
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rts5208: Avoid multiple assignment in one line
  2016-04-29  5:30 [PATCH] staging: rts5208: Avoid multiple assignment in one line Manav Batra
@ 2016-04-29  5:38 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-04-29  5:38 UTC (permalink / raw)
  To: Manav Batra; +Cc: devel, linux-kernel

On Thu, Apr 28, 2016 at 10:30:49PM -0700, Manav Batra wrote:
> Signed-off-by: Manav Batra <batmanav10@gmail.com>

I can't take patches without any changelog text :(

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] staging: rts5208: Avoid multiple assignment in one line
@ 2016-04-29  5:42 Manav Batra
  2016-04-30  0:47 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Manav Batra @ 2016-04-29  5:42 UTC (permalink / raw)
  To: devel, linux-kernel, gregkh

Signed-off-by: Manav Batra <batmanav10@gmail.com>

Separates out assignment in one line to two lines.
---
 drivers/staging/rts5208/rtsx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 25d095a..77c2580 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -105,13 +105,13 @@ static int slave_configure(struct scsi_device *sdev)
 	 * the actual value or the modified one, depending on where the
 	 * data comes from.
 	 */
-	if (sdev->scsi_level < SCSI_2)
-		sdev->scsi_level = sdev->sdev_target->scsi_level = SCSI_2;
-
+	if (sdev->scsi_level < SCSI_2) {
+		sdev->scsi_level  = SCSI_2;
+		sdev->sdev_target->scsi_level = SCSI_2;
+	}
 	return 0;
 }
 
-
 /***********************************************************************
  * /proc/scsi/ functions
  ***********************************************************************/
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rts5208: Avoid multiple assignment in one line
  2016-04-29  5:42 Manav Batra
@ 2016-04-30  0:47 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-04-30  0:47 UTC (permalink / raw)
  To: Manav Batra; +Cc: devel, linux-kernel

On Thu, Apr 28, 2016 at 10:42:07PM -0700, Manav Batra wrote:
> Signed-off-by: Manav Batra <batmanav10@gmail.com>
> 
> Separates out assignment in one line to two lines.

signed-off-by goes at the end of the text, not at the top.

Please fix all of these and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-30  0:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29  5:30 [PATCH] staging: rts5208: Avoid multiple assignment in one line Manav Batra
2016-04-29  5:38 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-04-29  5:42 Manav Batra
2016-04-30  0:47 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox