From: Manav Batra <batmanav10@gmail.com>
To: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: [PATCH] staging: rts5208: Avoid multiple assignment in one line
Date: Thu, 28 Apr 2016 22:42:07 -0700 [thread overview]
Message-ID: <20160429054207.GA4016@iiitd.ac.in> (raw)
Signed-off-by: Manav Batra <batmanav10@gmail.com>
Separates out assignment in one line to two lines.
---
drivers/staging/rts5208/rtsx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 25d095a..77c2580 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -105,13 +105,13 @@ static int slave_configure(struct scsi_device *sdev)
* the actual value or the modified one, depending on where the
* data comes from.
*/
- if (sdev->scsi_level < SCSI_2)
- sdev->scsi_level = sdev->sdev_target->scsi_level = SCSI_2;
-
+ if (sdev->scsi_level < SCSI_2) {
+ sdev->scsi_level = SCSI_2;
+ sdev->sdev_target->scsi_level = SCSI_2;
+ }
return 0;
}
-
/***********************************************************************
* /proc/scsi/ functions
***********************************************************************/
--
1.9.1
next reply other threads:[~2016-04-29 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 5:42 Manav Batra [this message]
2016-04-30 0:47 ` [PATCH] staging: rts5208: Avoid multiple assignment in one line Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-04-29 5:30 Manav Batra
2016-04-29 5:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429054207.GA4016@iiitd.ac.in \
--to=batmanav10@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox