From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbcD2MWI (ORCPT ); Fri, 29 Apr 2016 08:22:08 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34024 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752985AbcD2MWG (ORCPT ); Fri, 29 Apr 2016 08:22:06 -0400 Date: Fri, 29 Apr 2016 14:22:06 +0200 From: Johan Hovold To: Grigori Goronzy Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 03/13] USB: ch341: add definitions for modem control Message-ID: <20160429122206.GG22229@localhost> References: <1460754856-27908-1-git-send-email-greg@chown.ath.cx> <1460754856-27908-4-git-send-email-greg@chown.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460754856-27908-4-git-send-email-greg@chown.ath.cx> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 11:14:06PM +0200, Grigori Goronzy wrote: No commit message? > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index 1ab4384..db4b561 100644 > --- a/drivers/usb/serial/ch341.c > +++ b/drivers/usb/serial/ch341.c > @@ -61,6 +61,7 @@ > * the Net/FreeBSD uchcom.c driver by Takanori Watanabe. Domo arigato. > */ > > +#define CH341_MODEM_CTRL 0xA4 Please use the common CH341_REQ prefix and keep the requests sorted numerically. > #define CH341_REQ_WRITE_REG 0x9A > #define CH341_REQ_READ_REG 0x95 > #define CH341_REG_BREAK1 0x05 > @@ -162,7 +163,7 @@ static int ch341_set_baudrate(struct usb_device *dev, > > static int ch341_set_handshake(struct usb_device *dev, u8 control) > { > - return ch341_control_out(dev, 0xa4, ~control, 0); > + return ch341_control_out(dev, CH341_MODEM_CTRL, ~control, 0); > } > > static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv) Thanks, Johan