From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbcD2PQM (ORCPT ); Fri, 29 Apr 2016 11:16:12 -0400 Received: from mail.kernel.org ([198.145.29.136]:33698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbcD2PQK (ORCPT ); Fri, 29 Apr 2016 11:16:10 -0400 Date: Sat, 30 Apr 2016 00:16:05 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar Subject: Re: [RFC PATCH 0/8] perf tools: Update strbuf to remove xrealloc Message-Id: <20160430001605.fc259a090aea64d337e75892@kernel.org> In-Reply-To: <20160429145454.GK3386@kernel.org> References: <20160429144632.24984.93027.stgit@devbox> <20160429145454.GK3386@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Apr 2016 11:54:54 -0300 Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 29, 2016 at 11:46:32PM +0900, Masami Hiramatsu escreveu: > > Hi Arnaldo, > > > > This patch series does refactoring strbuf and xrealloc related code > > to remove xrealloc since it can call die() to exit immediately when > > it hits any error. Instead of that, it should return error code to > > the caller so that the caller can handle its error. > > > > Thus, at first, this changes the strbuf APIs to return error code > > instead of die() immediately. And then changing API callers according > > to the following rules. > > - Check the return value of strbuf APIs and handle errors and, > > - If the caller returns an error code (errno), it returns > > the return value of strbuf APIs. > > - If the caller just return -1 or NULl in error case, it also > > returns -1 or NULL in case of strbuf error. > > - If the caller can call die() directly, it also call die() > > in case of strbuf error. > > - Error checking patches are splitted for each subcommand, since > > it will help review. > > > > This also removes xrealloc and ALLOC_GROW from libperf, so that no > > one use it anymore. > > > > This series actually depends on the series of SDT support patches > > which I've sent an hour ago. It is also able to change this not to > > depend on it easily. Please ask me if you'd like so. > > Please do so, as this one looks easier to review, so can go in faster. OK, I sent it as v2 in order to avoid confusion. Thank you! -- Masami Hiramatsu