From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbcEANNw (ORCPT ); Sun, 1 May 2016 09:13:52 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38896 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401AbcEANNu (ORCPT ); Sun, 1 May 2016 09:13:50 -0400 Date: Sun, 1 May 2016 14:13:48 +0100 From: Matt Fleming To: Arnd Bergmann Cc: "Compostella, Jeremy" , Ingo Molnar , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efibc: avoid stack overflow warning Message-ID: <20160501131348.GS2839@codeblueprint.co.uk> References: <1461952128-2135409-1-git-send-email-arnd@arndb.de> <18565207.dPI1UNgYiO@wuerfel> <20160430224641.GQ2839@codeblueprint.co.uk> <2137916.p0oDBh93bk@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2137916.p0oDBh93bk@wuerfel> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 01 May, at 01:25:12AM, Arnd Bergmann wrote: > On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > > > It's not something we'd have to worry about in practice, but it does > > > make my patch incorrect. Should we come up with a different way to > > > do it? > > > > Jeremy proposed a patch to dynamically allocate the memory, which I > > think is the correct way to go given that our (reasonable) assumptions > > about reboot notifier concurrency are not guaranteed, > > > > https://lkml.kernel.org/r/87h9eked24.fsf@jcompost-MOBL1.tl.intel.com > > Sure, that works. I considered doing it that way but it seemed more > complicated. Please use that patch instead of mine. Thanks Ard!