From: Christoph Hellwig <hch@infradead.org>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>, paulmck@linux.vnet.ibm.com
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] target: use RCU_INIT_POINTER() when NULLing.
Date: Sun, 1 May 2016 10:01:20 -0700 [thread overview]
Message-ID: <20160501170120.GA15010@infradead.org> (raw)
In-Reply-To: <1462107122-9562-1-git-send-email-falakreyaz@gmail.com>
On Sun, May 01, 2016 at 06:22:01PM +0530, Muhammad Falak R Wani wrote:
> It is safe to use RCU_INIT_POINTER() to NULL, instead of
> rcu_assign_pointer().
> This results in slightly smaller/faster code.
If this is indeed the case, rcu_assign_pointer should simply check
for NULL using __builtin_constant_p and do the right thing transparently
instead of burdening it on every user.
next prev parent reply other threads:[~2016-05-01 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 12:52 [PATCH 2/2] target: use RCU_INIT_POINTER() when NULLing Muhammad Falak R Wani
2016-05-01 12:52 ` [PATCH 1/2] " Muhammad Falak R Wani
2016-05-01 17:01 ` Christoph Hellwig [this message]
2016-05-01 19:53 ` [PATCH 2/2] " Paul E. McKenney
2016-05-02 14:10 ` Paul E. McKenney
2016-05-02 17:57 ` Paul E. McKenney
2016-05-02 17:59 ` Christoph Hellwig
2016-05-02 18:06 ` Paul E. McKenney
2016-05-03 8:45 ` Christoph Hellwig
2016-05-03 13:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501170120.GA15010@infradead.org \
--to=hch@infradead.org \
--cc=falakreyaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox