From: Christoph Hellwig <hch@infradead.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, david@fromorbit.com, jack@suse.cz,
tytso@mit.edu, adilger.kernel@dilger.ca,
ross.zwisler@linux.intel.com, linux-nvdimm@ml01.01.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: Add alignment check for DAX mount
Date: Sun, 1 May 2016 10:31:15 -0700 [thread overview]
Message-ID: <20160501173115.GA21574@infradead.org> (raw)
In-Reply-To: <1461962375-3720-2-git-send-email-toshi.kani@hpe.com>
On Fri, Apr 29, 2016 at 02:39:33PM -0600, Toshi Kani wrote:
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 304c712..90a8670 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3421,6 +3421,12 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> "error: unsupported blocksize for dax");
> goto failed_mount;
> }
> + if (sb->s_bdev->bd_part->start_sect % (PAGE_SIZE / 512) ||
> + sb->s_bdev->bd_part->nr_sects % (PAGE_SIZE / 512)) {
> + ext4_msg(sb, KERN_ERR,
> + "error: unaligned partition for dax");
> + goto failed_mount;
> + }
> if (!sb->s_bdev->bd_disk->fops->direct_access) {
> ext4_msg(sb, KERN_ERR,
> "error: device does not support dax");
Factor your new checks and the ->direct_access into a new helper. It
should take the block device as file systems might have multiple
underlying devices.
next prev parent reply other threads:[~2016-05-01 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 20:39 [PATCH 0/3] Add alignment check for DAX mount Toshi Kani
2016-04-29 20:39 ` [PATCH 1/3] ext4: " Toshi Kani
2016-05-01 9:35 ` Boaz Harrosh
2016-05-01 17:31 ` Christoph Hellwig [this message]
2016-05-02 9:49 ` Boaz Harrosh
2016-05-02 15:23 ` Toshi Kani
2016-04-29 20:39 ` [PATCH 2/3] ext2: " Toshi Kani
2016-04-29 20:39 ` [PATCH 3/3] xfs: " Toshi Kani
2016-04-29 23:12 ` [PATCH 0/3] " Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501173115.GA21574@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox