From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbcEBF2x (ORCPT ); Mon, 2 May 2016 01:28:53 -0400 Received: from mail.kernel.org ([198.145.29.136]:58221 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbcEBF2o (ORCPT ); Mon, 2 May 2016 01:28:44 -0400 Date: Mon, 2 May 2016 08:27:55 +0300 From: Leon Romanovsky To: Muhammad Falak R Wani Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing. Message-ID: <20160502052755.GC10276@leon.nu> Reply-To: leon@kernel.org References: <1462106131-9073-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WplhKdTI2c8ulnbP" Content-Disposition: inline In-Reply-To: <1462106131-9073-1-git-send-email-falakreyaz@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WplhKdTI2c8ulnbP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 01, 2016 at 06:05:31PM +0530, Muhammad Falak R Wani wrote: > It is safe to use RCU_INIT_POINTER() to NULL a pointer, instead of > rcu_assign_pointer(). > This results in slightly smaller/faster code. >=20 > Signed-off-by: Muhammad Falak R Wani I'm fine with your commit message and don't need to resend, however the statements like "smaller code" need to be supported by =2E/scripts/bloat-o-meter and "faster code" by performance analysis. Reviewed-by: Leon Romanovsky > --- > drivers/staging/rdma/hfi1/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1= /init.c > index cfcdc16..34e0f90 100644 > --- a/drivers/staging/rdma/hfi1/init.c > +++ b/drivers/staging/rdma/hfi1/init.c > @@ -1303,7 +1303,7 @@ static void cleanup_device_data(struct hfi1_devdata= *dd) > =20 > spin_lock(&ppd->cc_state_lock); > cc_state =3D get_cc_state(ppd); > - rcu_assign_pointer(ppd->cc_state, NULL); > + RCU_INIT_POINTER(ppd->cc_state, NULL); > spin_unlock(&ppd->cc_state_lock); > =20 > if (cc_state) > --=20 > 1.9.1 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --WplhKdTI2c8ulnbP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXJuVbAAoJEORje4g2clinv+gP/Avy6Ojew6LJrAfIY7fr4MXo uZakvIwjLfafxZStV+ahu7/WjGkjMmxv9HeUQL1qxxmHmtY7puxNPXivi3bK+Xp7 mIiGJ1zt2ED0MmsF4MOF1rzpgnllRqPEWHmrVsidPnLeWsHouxAmEgul9CcRNUAJ /GUlm7AjDrq9K0Tr82fCRAdadbJApJu4j+94Ko5CfIvIThep6P5D3Mt8ur8XGjOg UsK3C8GS8UB+oFt4Wb8pqddpvNpg5keIVlFDP+eAT+E3C8jSym39DhHpcEpgzElQ 3oaqUT6pb4qwHT8Ix6iwvlTQAfyff9STa3HrNFShRspEdjLThqhQKjFJx3876bAA sTWdTBmW1v4jTX5S3f1Q4g49n5Llixnam5cK5Myhre40180KhEQa+OKUa+bweGPh 3yMeUQ5pxw0bzGTj7EOgOBGFLyBIwHMiVPMq22mkkWzns/lBGGPUbGltIyGRfGNs g2TtgTyZkMbesK4K4YxktVWrNRSmR6KcLyYyGU+m7s9eIdR4KrzQO6jcR6yQqUVe /fDpN6cCZJ3CfVcjEtfU2b7cBUnl0HVTFMTGoFAgYjtBVayarJqqODV/DrUoJQLR foODT6B41FdNLvg3O4Pxxi/GXgEatkTqnU2LtX5XE4XNTw6u1eAHGzK/FtB5etxq HN5dJmgMmfcGxDt1DVaB =d9ax -----END PGP SIGNATURE----- --WplhKdTI2c8ulnbP--