From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbcEBJU3 (ORCPT ); Mon, 2 May 2016 05:20:29 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36665 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752459AbcEBJUZ (ORCPT ); Mon, 2 May 2016 05:20:25 -0400 Date: Mon, 2 May 2016 18:21:57 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] zram: user per-cpu compression streams Message-ID: <20160502092157.GA21764@swordfish> References: <1461860230-849-1-git-send-email-sergey.senozhatsky@gmail.com> <1461860230-849-3-git-send-email-sergey.senozhatsky@gmail.com> <20160502062311.GB6077@bbox> <20160502072508.GA1811@swordfish> <20160502082822.GC6077@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160502082822.GC6077@bbox> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/02/16 17:28), Minchan Kim wrote: [..] > > aha... I misunderstood you. I thought you talked about the test results > > in particular, not about zram stats in general. hm, given that we don't > > close the door for 'idle compression streams list' yet, and may revert > > per-cpu streams, may be we can introduce this stat in 4.8? otherwise, in > > the worst case, we will have to trim a user visible stat file once again > > IF we, for some reason, will decide to return idle list back (hopefully > > we will not). does it sound OK to you to not touch the stat file now? > > My concern is how we can capture such regression without introducing > the stat of recompression? Do you have an idea? :) ...hm... inc ->failed_writes? ... or as a dirty and ugly and illegal (read "undocumented") hack, we probably can use ->failed_reads for that purpose. simply because I don't think any one has ever seen ->failed_reads != 0. -ss