From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbcEBKoG (ORCPT ); Mon, 2 May 2016 06:44:06 -0400 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:35019 "EHLO e06smtp08.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753544AbcEBKoD (ORCPT ); Mon, 2 May 2016 06:44:03 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Mon, 2 May 2016 12:43:56 +0200 From: Heiko Carstens To: Anna-Maria Gleixner Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Martin Schwidefsky , linux-s390@vger.kernel.org Subject: Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call Message-ID: <20160502104356.GB3974@osiris> References: <1462179612-55035-1-git-send-email-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462179612-55035-1-git-send-email-anna-maria@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16050210-0033-0000-0000-000013684726 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 11:00:12AM +0200, Anna-Maria Gleixner wrote: > Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out > in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > setup_pmc_cpu(). To keep the calling convention, interrupts are > explicitly disabled around the call. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org > Signed-off-by: Anna-Maria Gleixner > --- > Changes in v2: > - Adapt referenced commit in commit message > > arch/s390/kernel/perf_cpum_sf.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Acked-by: Heiko Carstens Same here: Martin, can you pick this one up, please?