From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754318AbcEBPtB (ORCPT ); Mon, 2 May 2016 11:49:01 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:19178 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbcEBPsw (ORCPT ); Mon, 2 May 2016 11:48:52 -0400 Date: Mon, 2 May 2016 11:47:25 -0400 From: Chris Mason To: Peter Zijlstra CC: Mike Galbraith , Ingo Molnar , Matt Fleming , Subject: Re: sched: tweak select_idle_sibling to look for idle threads Message-ID: <20160502154725.ckiewczbdubudyc7@floor.masoncoding.com> Mail-Followup-To: Chris Mason , Peter Zijlstra , Mike Galbraith , Ingo Molnar , Matt Fleming , linux-kernel@vger.kernel.org References: <20160405180822.tjtyyc3qh4leflfj@floor.thefacebook.com> <20160409190554.honue3gtian2p6vr@floor.thefacebook.com> <20160430124731.GE2975@worktop.cust.blueprintrf.com> <1462086753.9717.29.camel@suse.de> <20160502084615.GB3430@twins.programming.kicks-ass.net> <1462200604.3736.42.camel@suse.de> <20160502145817.GW3408@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160502145817.GW3408@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-02_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 04:58:17PM +0200, Peter Zijlstra wrote: > On Mon, May 02, 2016 at 04:50:04PM +0200, Mike Galbraith wrote: > > Oh btw, did you know single socket boxen have no sd_busy? That doesn't > > look right. > > I suspected; didn't bother looking at yet. The 'problem' is that the LLC > domain is the top-most, so it doesn't have a parent domain. I'm sure we > can come up with something if we can get this all working right. > > And yes, I can get gains on various workloads with various options, I > can even break all workloads, but I've so far completely failed on > getting a win for everyone :/ Adding in the task_hot() check to decide if scanning idle was a good idea ended up being really important. I'm happy to try a few variations here as well, do you have a more recent patch? -chris