public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
@ 2016-05-02 20:16 Patryk Mezydlo
  2016-05-02 20:47 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Patryk Mezydlo @ 2016-05-02 20:16 UTC (permalink / raw)
  To: greg; +Cc: lidza.louina, mwelling, linux-kernel

linux-kernel@vger.kernel.org
Bcc: 
Subject: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
Reply-To: 

This is a patch to the dgnc_cls.c file that fixes up a brace
warning found by the checkpatch.pl tool

Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 5e46ac8..f782904 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+	writeb((UART_FCR_ENABLE_FIFO
+		| UART_FCR_CLEAR_RCVR
+		| UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
+
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
  2016-05-02 20:16 [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Patryk Mezydlo
@ 2016-05-02 20:47 ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-05-02 20:47 UTC (permalink / raw)
  To: Patryk Mezydlo; +Cc: lidza.louina, mwelling, linux-kernel

On Mon, May 02, 2016 at 10:16:26PM +0200, Patryk Mezydlo wrote:
> linux-kernel@vger.kernel.org
> Bcc: 
> Subject: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
> Reply-To: 

Something went wrong on your end to have this show up in the email body
:(

Can you fix it up and resend?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
@ 2016-05-02 21:07 Patryk Mezydlo
  2016-05-02 21:55 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Patryk Mezydlo @ 2016-05-02 21:07 UTC (permalink / raw)
  To: greg; +Cc: lidza.louina, mwelling, linux-kernel

This is a patch to the dgnc_cls.c file that fixes up a brace
warning found by the checkpatch.pl tool

Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 5e46ac8..f782904 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+	writeb((UART_FCR_ENABLE_FIFO
+		| UART_FCR_CLEAR_RCVR
+		| UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
+
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
  2016-05-02 21:07 Patryk Mezydlo
@ 2016-05-02 21:55 ` Greg KH
  2016-05-02 22:04   ` mwelling
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2016-05-02 21:55 UTC (permalink / raw)
  To: Patryk Mezydlo; +Cc: lidza.louina, mwelling, linux-kernel

On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote:
> This is a patch to the dgnc_cls.c file that fixes up a brace
> warning found by the checkpatch.pl tool
> 
> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 5e46ac8..f782904 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
>  	/* Clear out UART and FIFO */
>  	readb(&ch->ch_cls_uart->txrx);
>  
> -	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
> +	writeb((UART_FCR_ENABLE_FIFO
> +		| UART_FCR_CLEAR_RCVR
> +		| UART_FCR_CLEAR_XMIT),
>  	       &ch->ch_cls_uart->isr_fcr);
> +

This isn't a "brace warning" fix.

And why add another blank line?

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
  2016-05-02 21:55 ` Greg KH
@ 2016-05-02 22:04   ` mwelling
  0 siblings, 0 replies; 5+ messages in thread
From: mwelling @ 2016-05-02 22:04 UTC (permalink / raw)
  To: Greg KH, Patryk Mezydlo; +Cc: lidza.louina, linux-kernel



On May 2, 2016 4:55:05 PM CDT, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote:
>> This is a patch to the dgnc_cls.c file that fixes up a brace
>> warning found by the checkpatch.pl tool
>> 
>> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
>> ---
>>  drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/staging/dgnc/dgnc_cls.c
>b/drivers/staging/dgnc/dgnc_cls.c
>> index 5e46ac8..f782904 100644
>> --- a/drivers/staging/dgnc/dgnc_cls.c
>> +++ b/drivers/staging/dgnc/dgnc_cls.c
>> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t
>*ch)
>>  	/* Clear out UART and FIFO */
>>  	readb(&ch->ch_cls_uart->txrx);
>>  
>> -	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR |
>UART_FCR_CLEAR_XMIT),
>> +	writeb((UART_FCR_ENABLE_FIFO
>> +		| UART_FCR_CLEAR_RCVR
>> +		| UART_FCR_CLEAR_XMIT),
>>  	       &ch->ch_cls_uart->isr_fcr);
>> +
>
>This isn't a "brace warning" fix.
>
>And why add another blank line?

Patryk,

Please post the checkpatch warning that was output so we can see what exactly was attempted to be corrected. 

Regards,

Michael 

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-02 22:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02 20:16 [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Patryk Mezydlo
2016-05-02 20:47 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-05-02 21:07 Patryk Mezydlo
2016-05-02 21:55 ` Greg KH
2016-05-02 22:04   ` mwelling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox