From: Gustavo Padovan <gustavo@padovan.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
dri-devel@lists.freedesktop.org,
"Daniel Stone" <daniels@collabora.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Greg Hackmann" <ghackmann@google.com>,
"John Harrison" <John.C.Harrison@Intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data
Date: Mon, 2 May 2016 18:11:51 -0300 [thread overview]
Message-ID: <20160502211151.GA2531@joana> (raw)
In-Reply-To: <20160502210007.GA2397@amd>
2016-05-02 Pavel Machek <pavel@ucw.cz>:
> On Wed 2016-04-27 13:27:08, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > struct sync_merge_data already have documentation on top of the
> > struct definition. No need to duplicate it.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> > @@ -33,8 +33,8 @@ struct sync_merge_data {
> > /**
> > * struct sync_fence_info - detailed fence information
> > * @obj_name: name of parent sync_timeline
> > - * @driver_name: name of driver implementing the parent
> > - * @status: status of the fence 0:active 1:signaled <0:error
> > +* @driver_name: name of driver implementing the parent
> > +* @status: status of the fence 0:active 1:signaled <0:error
>
> The whitespace (or mail client configuration?) looks wrong here.
this has been fixed in v2 already and Greg pulled everything into
staging next already.
Gustavo
next prev parent reply other threads:[~2016-05-02 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 16:27 [PATCH 00/12] De-stage Sync File Framework Gustavo Padovan
2016-04-27 16:27 ` [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-05-02 21:00 ` Pavel Machek
2016-05-02 21:11 ` Gustavo Padovan [this message]
2016-04-27 16:27 ` [PATCH 02/12] staging/android: drop sync_file_install() and sync_file_put() Gustavo Padovan
2016-04-27 16:27 ` [PATCH 03/12] staging/android: move sync_file functions comments to sync.c Gustavo Padovan
2016-04-27 16:27 ` [PATCH 04/12] staging/android: make sync_file_merge() static Gustavo Padovan
2016-04-27 16:27 ` [PATCH 05/12] staging/android: make sync_file_fdget() static Gustavo Padovan
2016-04-27 16:27 ` [PATCH 06/12] staging/android: prepare sync_file for de-staging Gustavo Padovan
2016-05-02 21:04 ` Pavel Machek
2016-05-02 21:13 ` Gustavo Padovan
2016-04-27 16:27 ` [PATCH 07/12] staging/android: improve documentation for sync_file Gustavo Padovan
2016-04-27 16:27 ` [PATCH 08/12] staging/android: style fix: alignment to match the open parenthesis Gustavo Padovan
2016-04-27 16:27 ` [PATCH 09/12] dma-buf/sync_file: de-stage sync_file headers Gustavo Padovan
2016-04-27 16:27 ` [PATCH 10/12] dma-buf/sync_file: de-stage sync_file Gustavo Padovan
2016-04-27 16:27 ` [PATCH 11/12] Documentation: include sync_file into DocBook Gustavo Padovan
2016-04-27 16:27 ` [PATCH 12/12] Documentation: add Sync File doc Gustavo Padovan
2016-04-27 19:05 ` Daniel Vetter
2016-04-27 19:09 ` [PATCH 00/12] De-stage Sync File Framework Daniel Vetter
2016-04-28 13:45 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502211151.GA2531@joana \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@Intel.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox