From: Greg KH <gregkh@linuxfoundation.org>
To: Patryk Mezydlo <mezydlo.p@gmail.com>
Cc: lidza.louina@gmail.com, mwelling@ieee.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
Date: Mon, 2 May 2016 14:55:05 -0700 [thread overview]
Message-ID: <20160502215505.GB16158@kroah.com> (raw)
In-Reply-To: <20160502210715.GA1214@debian>
On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote:
> This is a patch to the dgnc_cls.c file that fixes up a brace
> warning found by the checkpatch.pl tool
>
> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 5e46ac8..f782904 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
> /* Clear out UART and FIFO */
> readb(&ch->ch_cls_uart->txrx);
>
> - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
> + writeb((UART_FCR_ENABLE_FIFO
> + | UART_FCR_CLEAR_RCVR
> + | UART_FCR_CLEAR_XMIT),
> &ch->ch_cls_uart->isr_fcr);
> +
This isn't a "brace warning" fix.
And why add another blank line?
next prev parent reply other threads:[~2016-05-02 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 21:07 [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Patryk Mezydlo
2016-05-02 21:55 ` Greg KH [this message]
2016-05-02 22:04 ` mwelling
-- strict thread matches above, loose matches on Subject: below --
2016-05-02 20:16 Patryk Mezydlo
2016-05-02 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502215505.GB16158@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mezydlo.p@gmail.com \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox