From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933965AbcECQG4 (ORCPT ); Tue, 3 May 2016 12:06:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47204 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933511AbcECQGy (ORCPT ); Tue, 3 May 2016 12:06:54 -0400 Date: Tue, 03 May 2016 12:06:52 -0400 (EDT) Message-Id: <20160503.120652.1961585632822010448.davem@davemloft.net> To: lars.ellenberg@linbit.com Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit() From: David Miller In-Reply-To: <20160503100644.GE16459@soda.linbit> References: <57286F49.8050107@6wind.com> <1462268358-19044-1-git-send-email-nicolas.dichtel@6wind.com> <20160503100644.GE16459@soda.linbit> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 May 2016 09:06:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars Ellenberg Date: Tue, 3 May 2016 12:06:44 +0200 > Whereas using some arbitrary value will be wrong, > and will needlessly break userland. It cannot break userland. A fundamental property of netlink is that all code must silently ignore netlink attributes it does not understand. This is why netlink is easily extensible. If code isn't doing that, it is broken and must be fixed.