From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] zram: user per-cpu compression streams
Date: Tue, 3 May 2016 10:53:33 +0900 [thread overview]
Message-ID: <20160503015333.GA9987@swordfish> (raw)
In-Reply-To: <20160503014018.GB2272@bbox>
Hello Minchan,
On (05/03/16 10:40), Minchan Kim wrote:
> >
> > ...hm... inc ->failed_writes?
[..]
> Okay, let's add the knob to the existing sysfs(There is no different
> between sysfs and debugfs with point of userspace once they start to
> use it) because no need to add new code to avoid such mess.
>
> Any thoughts?
so you don't want to account failed fast-path writes in failed_writes?
it sort of kind of fits, to some extent. re-compression is, basically,
a new write operation -- allocate handle, map the page again, compress,
etc., etc. so in a sense failed fast-path write is _almost_ a failed write,
except that we took extra care of handling it and retried the op inside
of zram, not from bio or fs layer.
-ss
next prev parent reply other threads:[~2016-05-03 1:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 16:17 [PATCH 0/2] zram: switch to per-cpu compression streams Sergey Senozhatsky
2016-04-28 16:17 ` [PATCH 1/2] zsmalloc: require GFP in zs_malloc() Sergey Senozhatsky
2016-04-29 5:44 ` Minchan Kim
2016-04-29 7:30 ` Sergey Senozhatsky
2016-04-28 16:17 ` [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky
2016-05-02 6:23 ` Minchan Kim
2016-05-02 7:25 ` Sergey Senozhatsky
2016-05-02 8:06 ` Sergey Senozhatsky
2016-05-03 5:23 ` Minchan Kim
2016-05-03 5:40 ` Minchan Kim
2016-05-03 5:57 ` Sergey Senozhatsky
2016-05-03 6:19 ` Minchan Kim
2016-05-03 7:01 ` Sergey Senozhatsky
2016-05-03 5:44 ` Sergey Senozhatsky
2016-05-02 8:28 ` Minchan Kim
2016-05-02 9:21 ` Sergey Senozhatsky
2016-05-03 1:40 ` Minchan Kim
2016-05-03 1:53 ` Sergey Senozhatsky [this message]
2016-05-03 2:20 ` Minchan Kim
2016-05-03 2:30 ` Sergey Senozhatsky
2016-05-03 4:29 ` Sergey Senozhatsky
2016-05-03 5:03 ` Minchan Kim
2016-05-03 6:53 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503015333.GA9987@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox